perf(@angular-devkit/build-angular): inject Sass import/use directive importer information when resolving #25534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
added
the
action: review
clydin
force-pushed
the
sass/import-use-lexer
branch
from
67916f5
to
0cc760a
Compare
dgp1130
reviewed
Jul 13, 2023
packages/angular_devkit/build_angular/src/tools/sass/rebasing-importer.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/tools/sass/rebasing-importer.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/tools/sass/rebasing-importer.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/tools/sass/rebasing-importer.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/tools/sass/rebasing-importer.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/tools/sass/rebasing-importer.ts
Outdated
Show resolved
Hide resolved
clydin
force-pushed
the
sass/import-use-lexer
branch
2 times, most recently
from
e57753a
to
320e5fc
Compare
dgp1130
approved these changes
Jul 14, 2023
packages/angular_devkit/build_angular/src/tools/sass/rebasing-importer.ts
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/tools/sass/rebasing-importer.ts
Outdated
Show resolved
Hide resolved
… importer information when resolving To correctly resolve a package based import reference in a Sass file with pnpm or Yarn PnP, the importer file path must be known. Unfortunately, the Sass compiler does not provided the importer file to import plugins. Previously to workaround this issue, all previously resolved stylesheets were tried as the importer path. This allowed the stylesheets to be resolved but it also could cause a potentially large increase in build time due to the amount of previous stylesheets that would need to be tried. To avoid the performance impact and to also provide more accurate information regarding the importer file, a lexer is now used to extract import information for a stylesheet and inject the importer file path into the specifier. This information is then extracted from the import specifier during the Sass resolution process and allows the underlying package resolution access to a viable location to resolve the package for all package managers. This information is currently limited to specifiers referencing the `@angular` and `@material` package scopes but a comprehensive pre-resolution process may be added in the future.
clydin
force-pushed
the
sass/import-use-lexer
branch
from
320e5fc
to
425f04f
Compare
clydin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To correctly resolve a package based import reference in a Sass file with pnpm or Yarn PnP, the importer file path must be known. Unfortunately, the Sass compiler does not provided the importer file to import plugins. Previously to workaround this issue, all previously resolved stylesheets were tried as the importer path. This allowed the stylesheets to be resolved but it also could cause a potentially large increase in build time due to the amount of previous stylesheets that would need to be tried. To avoid the performance impact and to also provide more accurate information regarding the importer file, a lexer is now used to extract import information for a stylesheet and inject the importer file path into the specifier. This information is then extracted from the import specifier during the Sass resolution process and allows the underlying package resolution access to a viable location to resolve the package for all package managers. This information is currently limited to specifiers referencing the
@angularand@materialpackage scopes but a comprehensive pre-resolution process may be added in the future.